-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Services menu in JLab has multiple behaviors #2711
Comments
"internal"/"External" isn't a good description of what these are. |
The menu is currently defined in: Lines 47 to 108 in d22e5cb
Some functions are implemented in https://github.com/nebari-dev/jupyterlab-nebari-mode extension. For compatibility when jupyterlab-conda-store extension is disabled or not installed it will open the Environment Management tab externally in new tab. |
We can add the divider easily. We can add non-clickable "Internal"/"External" entries. We can:
The problem will be if an admin disabled https://github.com/conda-incubator/jupyterlab-conda-store and now it does not open in JupyterLab. I think I would prefer to change the menu items to show [↗] as the label can be set separately for the scenario when |
I agree internal/external seems like the wrong labels. Conda store (Environment Management) is external to Nebari as well. It just happens to be developed by Quansight as well, but it's a separate open source project the same as Keycloak (User Management) or any of the others. Update: I realize you mean internal/external windows, but it wouldn't have been clear to me without the explanation above. |
I love this idea! |
Context
The services menu in JLab behaves differently based on which of the options you choose. Its disorienting for users when conda-store opens within the JLab window, but other options open in a new tab.
A solution would be to visually breakdown the services menu so users have a concept that the behavior is different.
Here is an initial design for this breakdown:
Value and/or benefit
Users have a visual indication that some services are different from others and therefore the result of clicking on them is not disorienting.
Anything else?
No response
The text was updated successfully, but these errors were encountered: