Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Budget increases when management overlaps or is out of model bounds #3

Open
ChrisJones687 opened this issue Oct 2, 2019 · 2 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request
Milestone

Comments

@ChrisJones687
Copy link
Member

This is can be resolved currently in the backend but would ultimately we want to handle this on the frontend so that the user gets more accurate feedback.

@ChrisJones687 ChrisJones687 added the bug Something isn't working label Oct 3, 2019
@ChrisJones687 ChrisJones687 added this to the Version 1.0.0 milestone Oct 3, 2019
@ChrisJones687
Copy link
Member Author

@shannonkjones
Copy link
Member

There are two ways we could approach this.

(1) On the frontend (in the browser). In that case, I think we should bring in turf.js. It has a cleanCoords and bboxClip method that I think will handle the overlapping management and the out of model bounds issues.

(2) On the backend (in the Django view). If we're going to be using web sockets to draw management and update the database in real time, then this could happen on the Django backend. In that case, the polygons could be cleaned up in python on the server before being passed back to the client. This might be preferable since there is already so much happening on the client side.

@ChrisJones687 ChrisJones687 added the enhancement New feature or request label Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants