Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test_date_range to handle flagged data #23

Open
wright13 opened this issue Dec 2, 2022 · 1 comment
Open

Update test_date_range to handle flagged data #23

wright13 opened this issue Dec 2, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@wright13
Copy link
Collaborator

wright13 commented Dec 2, 2022

Consider updating test_date_range to only consider good data and ignore any dates flagged as rejected. Realistically, flags may vary across networks, so maybe provide arguments that let the user specify the name of the flag column and the codes that indicate rejected data

@wright13 wright13 added the enhancement New feature or request label Dec 2, 2022
@RobLBaker
Copy link
Member

This is a great idea! As a first pass it's worth supporting the "R" flag for rejected. We can work on supporting people who choose not to use the recommended flags at a later stage in development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants