Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor data_table_congruence sapply to vapply #127

Open
RobLBaker opened this issue Jan 16, 2024 · 0 comments
Open

Refactor data_table_congruence sapply to vapply #127

RobLBaker opened this issue Jan 16, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed refactor Code style improvements

Comments

@RobLBaker
Copy link
Member

Basically, codefactor thinks all sapply() calls should be re-written as vapply(). I'm inclined to think it doesn't really matter much, but if anyone wants to go chase that codefactor A rating, this these are the things that need to be refactored.

CodeFactor found multiple issues:

Function "sapply" is undesirable. As an alternative, use vapply() with an appropriate FUN.VALUE= argument to obtain type-stable simplification.
R\tabular_data_congruence.R:1351
Commit RobLBaker@d3c8886
R\tabular_data_congruence.R:1070
Commit RobLBaker@d3c8886
R\tabular_data_congruence.R:1025
Commit RobLBaker@d3c8886
R\tabular_data_congruence.R:734
Commit RobLBaker@d3c8886
R\tabular_data_congruence.R:712
Commit RobLBaker@d3c8886
R\tabular_data_congruence.R:264
Commit RobLBaker@d3c8886
R\tabular_data_congruence.R:219
Commit RobLBaker@d3c8886
R\tabular_data_congruence.R:555
Commit RobLBaker@0d55e6d
R\tabular_data_congruence.R:547
Commit RobLBaker@0d55e6d
R\tabular_data_congruence.R:75
Commit RobLBaker@ee8d3ef

@RobLBaker RobLBaker added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed refactor Code style improvements labels Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed refactor Code style improvements
Projects
None yet
Development

No branches or pull requests

1 participant