Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full logging support on standard out #10

Open
collinss-jpl opened this issue Jan 19, 2022 · 7 comments
Open

Full logging support on standard out #10

collinss-jpl opened this issue Jan 19, 2022 · 7 comments
Assignees

Comments

@collinss-jpl
Copy link

Logging sent to standard out by the DSWx-HLS SAS Interface delivery does not include all the formatting that is included when creating a log file with the --log option.

Logging sent to standard out should be configurable to include all comma-delimited metadata columns, for example:

2021-11-03 20:13:08.795, INFO, DSWx-HLS, dswx_hls, 999999, DSWx-HLS-0.1/bin/dswx_hls.py:1048, "Input runconfig file: runconfig/runconfig_dswx_hls.yaml"

The PGE layer is designed to incorporate the SAS logging sent to standard out, and parses the additional metadata fields from both the PGE and SAS log sections for metrics reporting.

@hfattahi
Copy link
Contributor

@LiangJYu @vbrancat and @yunjunz whatever we agree on for the logging style for this SAS will be also adopted for others SASes including COMPASS.

@gshiroma
Copy link
Collaborator

The log formatting was fixed and merged to the main repository here .

@collinss-jpl collinss-jpl self-assigned this Mar 24, 2022
@collinss-jpl
Copy link
Author

Hi @gshiroma, I opened this ticket to specifically address the lack of formatted log messages on the console (aka standard out). Formatting has always been present, but it only appeared in the log file. I will put together a simple PR soon that will allow the PGE to enable formatted logging to the console.

@collinss-jpl collinss-jpl reopened this Mar 24, 2022
@hfattahi
Copy link
Contributor

hfattahi commented Mar 24, 2022

Thanks @collinss-jpl . If you point us to what you are planning/doing on PGE side, we may just copy the same thing.

@collinss-jpl
Copy link
Author

@hfattahi this will actually be a small change to the proteus code itself, basically just addition of a --verbose flag that the PGE can use to enable formatted messages on the console. The flag will be false by default, so the console logging can remain the way y'all are used to seeing it for your testing.

@hfattahi
Copy link
Contributor

Great. Thanks Scott. Looking forward to the PR.

@gshiroma
Copy link
Collaborator

Thank you, @collinss-jpl . Sorry, for some reason in my mind this issue had to do with logging to file rather than stdout 😅.

I've been using --verbose in some scripts to print "extra messages", so I guess I'll use a different flag to change the stdout format, maybe something like --stdout-full-logging. Please let me know if you have other suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants