Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emtpy Space when small counter layout is used #66

Open
vabene1111 opened this issue Sep 10, 2020 · 1 comment · May be fixed by #75
Open

Emtpy Space when small counter layout is used #66

vabene1111 opened this issue Sep 10, 2020 · 1 comment · May be fixed by #75

Comments

@vabene1111
Copy link
Contributor

You introduced a small counter layout some updates back which makes a lot of sense for smaller devices and for any screen size after a certain amount of counters.

Although the feature is great, on a big device switching at 5 counters on bigger devices leaves a lot of free space. This might also be an issue on really large devices such as tablets but i haven't tested that.


I see the following options

  • make the threshold configurable in the settings
  • make the small layout have variable (parent filling) height
  • leave it as is because its meant to be this way

any preferences ?
@n-apps
Copy link
Owner

n-apps commented Sep 13, 2020

calculate the threshold based on device's screen or (if it's too complicated) make the threshold configurable in the settings

@vabene1111 vabene1111 linked a pull request Oct 1, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added ability to change number of full counters vabene1111/ScoreCounter
2 participants
@vabene1111 @n-apps