-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configure how often upload progress is sent trough JS bridge. #17
Comments
I think the main problem is we have too many file access for The |
We could actually just have an option to disable the progress event emitter all together? I feel like it wouldn't be wise to throttle the error or state changed event emitters. I can mock this up and submit a PR soon enough |
What about creating a separate issue for disabling the progress event emitter ? About errors I agree the shouldn't be throttled, but sent in a separated event, in that way you could have progress every X time, and errors as soon as they happen.
|
@jhen0409 If you're using redux-persist, I suspect that's the cause of the contentious AsyncStorage calls. We gave up on redux-persist for now, because of this issue, and because there's a bug that prevents it from handing scalars correctly. Ultimately, you only need to write the store to disk before the app exits; this can easily be done with some judicious use of a custom |
sending data too frequently, when tracking several big uploads, can affect the performance of the app, would be great to have a `progressUpdateInterval' option .
The text was updated successfully, but these errors were encountered: