Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PageContainer] Setting title prop manually gives all children title tooltip #4452

Open
christiancookbuzz opened this issue Nov 22, 2024 · 4 comments
Labels
bug 🐛 Something doesn't work component: PageContainer good first issue Great for first contributions. Enable to learn the contribution process. scope: toolpad-core Abbreviated to "core"

Comments

@christiancookbuzz
Copy link

christiancookbuzz commented Nov 22, 2024

Steps to reproduce

Steps:

  1. Add a PageContainer component
  2. Give the PageContainer a title prop (Overriding default behaviour) e.g. title='Test'
  3. Within the PageContainer component, add an element e.g. Button
  4. Load the page and hover on the Button and observe the title from the PageContainer is applied to the button, displaying a title tooltip with your PageContainer's title

image

Current behavior

Child elements to the PageContainer (And PageContainer itself) all display a title browser tooltip.

Expected behavior

No title tooltip should be displayed.

Context

I am trying to override the title for a page based on the context of where the page is being displayed without changing the title in the navigation.

Your environment

npx @mui/envinfo
  System:
    OS: macOS 14.4.1
  Binaries:
    Node: 18.19.0 - ~/.nvm/versions/node/v18.19.0/bin/node
    npm: 9.9.2 - ~/.nvm/versions/node/v18.19.0/bin/npm
    pnpm: Not Found
  Browsers:
    Chrome: 131.0.6778.86
    Edge: Not Found
    Safari: 17.4.1
  npmPackages:
    @emotion/react: ^11.11.4 => 11.13.3 
    @emotion/styled: ^11.11.0 => 11.13.0 
    @mui/base:  5.0.0-beta.61 
    @mui/core-downloads-tracker:  6.1.8 
    @mui/icons-material: ^6.1.0 => 6.1.1 
    @mui/lab: ^6.0.0-beta.10 => 6.0.0-beta.14 
    @mui/material: ^6.1.0 => 6.1.8 
    @mui/private-theming:  6.1.8 
    @mui/styled-engine:  6.1.8 
    @mui/styled-engine-sc: ^6.1.0 => 6.1.1 
    @mui/system:  6.1.8 
    @mui/types:  7.2.19 
    @mui/utils:  6.1.8 
    @mui/x-charts: ^7.15.0 => 7.17.0 
    @mui/x-charts-vendor:  7.16.0 
    @mui/x-data-grid:  7.17.0 
    @mui/x-data-grid-pro: ^7.17.0 => 7.17.0 
    @mui/x-date-pickers: ^7.16.0 => 7.17.0 
    @mui/x-internals:  7.17.0 
    @mui/x-license:  7.17.0 
    @toolpad/core: ^0.9.0 => 0.9.0 
    @toolpad/utils:  0.9.0 
    @types/react: ^18.2.66 => 18.3.7 
    react: ^18.2.0 => 18.3.1 
    react-dom: ^18.2.0 => 18.3.1 
    styled-components: ^6.1.8 => 6.1.13 
    typescript: ^5.2.2 => 5.6.2 

Browser: Chrome

Search keywords: PageContainer title

@christiancookbuzz christiancookbuzz added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Nov 22, 2024
@Janpot
Copy link
Member

Janpot commented Nov 22, 2024

it's spreading the title prop to the top level element. this is unintended. PR welcome.

@Janpot Janpot added bug 🐛 Something doesn't work good first issue Great for first contributions. Enable to learn the contribution process. component: PageContainer and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Nov 22, 2024
@prakhargupta1 prakhargupta1 added the scope: toolpad-core Abbreviated to "core" label Nov 25, 2024
@christiancookbuzz
Copy link
Author

@Janpot Would you consider a change to the title prop name to something like pageTitle so it doesn't conflict with the title global attribute?

@Janpot
Copy link
Member

Janpot commented Nov 26, 2024

I think we could start by destructuring it here so that it doesn't end up in the rest variable. renaming it would be a breaking change.

@christiancookbuzz
Copy link
Author

Thanks @Janpot I will get a PR in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: PageContainer good first issue Great for first contributions. Enable to learn the contribution process. scope: toolpad-core Abbreviated to "core"
Projects
Status: Backlog
Development

No branches or pull requests

3 participants