New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace toastr with something more modern #7745

Open

NBKelly opened this issue Sep 18, 2024 · 1 comment

Collaborator

NBKelly commented Sep 18, 2024

Toastr is nice, but it hasn't been updated or touched in the last seven years at all, and it has a few issues:

XSS Vulnerability "HIGH" due to default escapeHtml=false setting CodeSeven/toastr#689 - there are XSS vulnerabilities we have to watch out for (currently, I think it's only possible for a user to hurt themselves)
This project is not maintained (2023) CodeSeven/toastr#698 - names clash with bootstrap

We could potentially look at using something like this in the future:

https://github.com/apvarun/toastify-js/tree/master

Collaborator Author

NBKelly commented Sep 19, 2024

Could potentially allow us to do fancy stuff like #5727, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment