Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lag when clicking the "draw card" button can lead to ruined games #5213

Closed
NBKelly opened this issue Jul 25, 2020 · 1 comment · May be fixed by #7640
Closed

Lag when clicking the "draw card" button can lead to ruined games #5213

NBKelly opened this issue Jul 25, 2020 · 1 comment · May be fixed by #7640

Comments

@NBKelly
Copy link
Collaborator

NBKelly commented Jul 25, 2020

Sometimes when playing, it is possible that small moments of lag (at either end, or anywhere inbetween) when performing the draw card (or fire subroutines, if it happens to be damage) actions may lead to the actions being taken twice. Alternatively, it may seem that the interface is unresponsive (I clicked draw 10 seconds ago and it didn't draw, so I'll click it again) leading to mistaken double or triple draws.

I can think of two cases that may cause issues:'

  • Multiple 'draw card' or 'fire subroutine' prompts are sent within a small amount of time
  • Multiple 'draw card' or 'fire subroutine' prompts are received by the server within a small amount of time

I think that both of these cases could (maybe) be detected serverside, and it may be possible to correct them (ie send prompts instead of executing duplicated actions).

@NBKelly
Copy link
Collaborator Author

NBKelly commented Oct 11, 2024

Closing this as stale (I'm happy with our network state now)

@NBKelly NBKelly closed this as not planned Won't fix, can't repro, duplicate, stale Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant