Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tjCompress2 does not perform high compression #386

Open
espresso3389 opened this issue Jan 19, 2021 · 4 comments
Open

tjCompress2 does not perform high compression #386

espresso3389 opened this issue Jan 19, 2021 · 4 comments

Comments

@espresso3389
Copy link

I've been evaluating MozJpeg's tjCompress2 function using tjexample (with only input/output filenames but no more options).
The problem is that the latest master commit (1a7384c) does "normal" JPEG compression and the result seems to be identical to normal libjpeg-turbo.

  • It seem the last commit that works well is 6d95c51.
  • bit bisect start HEAD 6d95c51a indicates that the ultimate cause is 044c22e, that is on libjpeg-turbo 2.0.5 branch.
  • And the commit b3e7390 (that merges the branch) broke the master branch.

I've checked the commit, 044c22e, but I could not found anything related to the actual behavior but there're changes on unit tests... :(

@kornelski
Copy link
Member

I didn't think anyone used this API instead of the standard libjpeg API.

MozJPEG reuses unit tests from libjpeg-trubo, and it happens that unit tests rely on this function being bit-identical to libjpeg-turbo.

@espresso3389
Copy link
Author

If so, please document the fact somewhere.

FYI, at least, MozJpegSharp depends on the function.

@kornelski
Copy link
Member

Ok. I'll try to make it work with improved compression.

@PJK136
Copy link

PJK136 commented Jan 20, 2021

I think it's the same problem I have with #381.

I just dirtily reverted f1d512d to make it works, but I'm interested in a proper fix/workaround too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants