Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question regarding PR review process #551

Open
Nagidrop opened this issue Nov 6, 2024 · 1 comment
Open

Question regarding PR review process #551

Nagidrop opened this issue Nov 6, 2024 · 1 comment

Comments

@Nagidrop
Copy link

Nagidrop commented Nov 6, 2024

I have been Nilesoft Shell user for quite some time. It has saved me from the sluggish Windows defaults, drastically enhanced my experience and boosted my productivity through customizations. I'm so grateful that you made this wonderful software free to use without any charges :D

Lately I noticed it has been open-sourced for almost a year. With a quick glimpse through the PRs, I promptly spotted these 2 conflicting ones that you merged without comments: #529 and #530. It seems that you merged these without reviewing. If it keeps on occuring, I'm concerned about Shell's quality being degraded in the long run.

As a loyal user and supporter of Shell project, I want to raise and make aware of this issue, to help Nilesoft Shell development and ensure it isn't stalled or degraded after merging new PRs. I would love to hear your thoughts :D

@moudey
Copy link
Owner

moudey commented Dec 6, 2024

Hi @Nagidrop, Thank you for your interest and concern. Editing configuration files for other languages has not been reviewed yet. However, this issue has been overcome in version 1.9.19 now that the language has been separated from the configuration file code, which will make it easier to add other languages without editing the configuration file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants