Missing API token exception message could be improved

[baydrift]

Could get remote host with ID 'jenkins (at) sjsfwxd6jenkins03' configured in Jenkins global configuration. Please check your global configuration.''

is missing a crucial "not"

[baydrift]

commit 1b3f32a4366bf56427f4aa8b1cc86f94e1111da7 (HEAD -> Add_missing_not)
Author: Andy Stout [email protected]
Date: Thu Feb 10 16:57:26 2022 +0000

Add missing 'not' to exception message

diff --git a/src/main/java/org/jenkinsci/plugins/ParameterizedRemoteTrigger/RemoteBuildConfiguration.java b/src/main/java/org/jenkinsci/plugins/ParameterizedRemoteTrigger/RemoteBuildConfiguration.java
index 8e830a5..fff6e99 100644
--- a/src/main/java/org/jenkinsci/plugins/ParameterizedRemoteTrigger/RemoteBuildConfiguration.java
+++ b/src/main/java/org/jenkinsci/plugins/ParameterizedRemoteTrigger/RemoteBuildConfiguration.java
@@ -445,7 +445,7 @@ public class RemoteBuildConfiguration extends Builder implements SimpleBuildStep
throw new AbortException("Configuration of the remote Jenkins host is missing.");
if (!isRemoteUrlSet && !isRemoteNameEmpty && globallyConfiguredServer == null)
throw new AbortException(String.format(

•                                                   "Could get remote host with ID '%s' configured in Jenkins global configuration. Please check your global configuration.",
  

•                                                   "Could not get remote host with ID '%s' configured in Jenkins global configuration. Please check your global configuration.",
                                                    this.remoteJenkinsName));
                    }
                    // Generic error message
  

diff --git a/src/test/java/org/jenkinsci/plugins/ParameterizedRemoteTrigger/RemoteBuildConfigurationTest.java b/src/test/java/org/jenkinsci/plugins/ParameterizedRemoteTrigger/RemoteBuildConfigurationTest.java
index b4a5897..76a7a7c 100644
--- a/src/test/java/org/jenkinsci/plugins/ParameterizedRemoteTrigger/RemoteBuildConfigurationTest.java
+++ b/src/test/java/org/jenkinsci/plugins/ParameterizedRemoteTrigger/RemoteBuildConfigurationTest.java
@@ -363,7 +363,7 @@ public class RemoteBuildConfigurationTest {
config.evaluateEffectiveRemoteHost(null);
}
catch (AbortException e) {

•        assertEquals("Could get remote host with ID 'notConfiguredRemoteHost' configured in Jenkins global configuration. Please check your global configuration.", e.getMessage());
  

•        assertEquals("Could not get remote host with ID 'notConfiguredRemoteHost' configured in Jenkins global configuration. Please check your global configuration.", e.getMessage());
     }
  

  }