Skip to content
This repository has been archived by the owner on Oct 4, 2021. It is now read-only.

Handles disposed windows when they are closed while checking windows loop #9109

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Handles disposed windows when they are closed while checking windows loop #9109

wants to merge 2 commits into from

Conversation

netonjm
Copy link
Contributor

@netonjm netonjm commented Oct 28, 2019 •
edited
Loading

This fix, adds in the CommandManager some logic to unsuscribe closed native windows.
and also adds a try/catch with logging in current OpenWindowListHandler

Fixes VSTS #999372 - System.ObjectDisposedException exception in Foundation.NSObject.get_SuperHandle()

@netonjm netonjm requested a review from sevoku October 28, 2019 13:16
@netonjm netonjm self-assigned this Oct 28, 2019
@netonjm netonjm requested review from slluis and Therzok October 28, 2019 13:19
@netonjm netonjm changed the title Handles disposed windows when they are closed while the windows loop Handles disposed windows when they are closed while checking windows loop Oct 28, 2019
Therzok
Therzok suggested changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@Therzok Therzok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a hack and not a real fix.

@netonjm
Copy link
Contributor Author

netonjm commented Dec 3, 2019

@monojenkins rebase

@netonjm netonjm requested a review from Therzok December 3, 2019 10:56
@netonjm
Copy link
Contributor Author

netonjm commented Dec 9, 2019

@monojenkins rebase

@netonjm
Copy link
Contributor Author

netonjm commented Jan 7, 2020

@monojenkins rebase

@netonjm
Copy link
Contributor Author

netonjm commented Jan 14, 2020

rebased!

@Therzok
Copy link
Contributor

Therzok commented Jan 21, 2020

@monojenkins rebase

@VladyslavKostin
Copy link

VladyslavKostin commented Jan 22, 2020 •
edited
Loading

@netonjm @Therzok
rebase didn't help, something was wrong with "Build monodevelop" task, maybe reopen pr will rid of the issue

@mrward
Copy link
Member

mrward commented Jan 22, 2020

Looks like a problem with the code. The build error is:

MonoDevelop.Ide.Commands/WindowCommands.cs(268,14): error CS0246: The type or namespace name 'Exception' could not be found (are you missing a using directive or an assembly reference?) [/Users/runner/runners/2.164.3/work/1/s/monodevelop/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.csproj]

WindowCommands is using Exception but does not have a using System; statement.

@netonjm
Removes from topLevelWindows destroyed native windows to avoid dispos…
13ac487 
…ed exceptions

Fixes VSTS #999372 - System.ObjectDisposedException exception in Foundation.NSObject.get_SuperHandle()
@netonjm
Handles disposed windows when they are closed while the windows loop
34550e3
@netonjm
Copy link
Contributor Author

netonjm commented Jan 22, 2020

Fixed build issue and rebased! Thank you guys!

Base automatically changed from master to main March 9, 2021 14:17
@akoeplinger akoeplinger changed the base branch from main to master March 15, 2021 17:01
Base automatically changed from master to main March 15, 2021 17:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Therzok Therzok Therzok approved these changes

@sevoku sevoku Awaiting requested review from sevoku

@slluis slluis Awaiting requested review from slluis

At least 2 approving reviews are required to merge this pull request.

Assignees

@netonjm netonjm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@netonjm @Therzok @VladyslavKostin @mrward