Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hash the map on the backend and compare against other map hashes to prevent duplicate file uploading #245

Open
Gocnak opened this issue Dec 9, 2018 · 3 comments · May be fixed by #1082
Open

Hash the map on the backend and compare against other map hashes to prevent duplicate file uploading #245

Gocnak opened this issue Dec 9, 2018 · 3 comments · May be fixed by #1082
Labels
For: Backend This is something to do for the backend (server folder) of the website. Good first issue A perfect issue for newcomers to jump into helping out while learning the codebase! Priority: Medium Something that should be tried to be done in this release, but not as important as High priority. Size: Small Something that may take a day at most to do. Type: Enhancement Something that builds on top of what already exists

Comments

@Gocnak
Copy link
Member

Gocnak commented Dec 9, 2018

No description provided.

@Gocnak Gocnak added Size: Small Something that may take a day at most to do. future Type: Enhancement Something that builds on top of what already exists and removed future Size: Small Something that may take a day at most to do. labels Dec 9, 2018
@Gocnak Gocnak added this to the 1.0.0 milestone Mar 30, 2019
@Gocnak Gocnak added For: Backend This is something to do for the backend (server folder) of the website. For: Frontend This is something to do for the front end (client folder) of the website. Priority: Medium Something that should be tried to be done in this release, but not as important as High priority. Size: Small Something that may take a day at most to do. labels Aug 6, 2020
@Gocnak Gocnak moved this to To Do in 0.11.0 Release Oct 16, 2022
@tsa96
Copy link
Member

tsa96 commented Jun 23, 2023

https://developer.mozilla.org/en-US/docs/Web/API/SubtleCrypto/digest

@tsa96
Copy link
Member

tsa96 commented Mar 16, 2024

@Gocnak why do we actually need this? Maps are human moderated, and someone uploading a duplicate map seems so unlikely anyway.

The one place I think it could be worthwhile is when users submit new MapSubmissionVersions, since it's a very easy check and maaaybe someone accidentally uploads the same version multiple times. That can be done in just backend code. I can do that when I next worked on map submission.

@Gocnak Gocnak removed this from the 1.0.0 milestone Apr 27, 2024
@tsa96
Copy link
Member

tsa96 commented Jun 16, 2024 •
edited
Loading

Okay we can do this on backend in maps.service.ts code, should be able to do it with a single Prisma query. Make sure we have E2E tests for this obviously!

Probably fine to just check against approved map hashes, though I guess no harm in MapSubmissionVersions

@tsa96 tsa96 added Good first issue A perfect issue for newcomers to jump into helping out while learning the codebase! and removed For: Frontend This is something to do for the front end (client folder) of the website. labels Jun 16, 2024
@Gocnak Gocnak changed the title Hash the map on the client and compare against server to prevent duplicate file uploading Hash the map on the backend and compare against other map hashes to prevent duplicate file uploading Jun 16, 2024
@Gocnak Gocnak removed this from 0.11.0 Release Aug 11, 2024
@github-project-automation github-project-automation bot moved this to In Progress in Next Release Aug 14, 2024
@jef jef linked a pull request Dec 11, 2024 that will close this issue
Draft
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
For: Backend This is something to do for the backend (server folder) of the website. Good first issue A perfect issue for newcomers to jump into helping out while learning the codebase! Priority: Medium Something that should be tried to be done in this release, but not as important as High priority. Size: Small Something that may take a day at most to do. Type: Enhancement Something that builds on top of what already exists
Projects
Next Release
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: throw error if duplicate map jef/momentum-mod-website
2 participants
@Gocnak @tsa96