Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix POM in 0.9.0 #86

Closed
mkobit opened this issue May 28, 2019 · 5 comments
Closed

Fix POM in 0.9.0 #86

mkobit opened this issue May 28, 2019 · 5 comments
Assignees
Milestone

Comments

@mkobit
Copy link
Owner

mkobit commented May 28, 2019

Starting a Gradle Daemon, 3 incompatible and 1 stopped Daemons could not be reused, use --status for details           

FAILURE: Build failed with an exception.

* What went wrong:                                         
A problem occurred configuring root project 'jenkins-pipeline-shared-library-example'.                                 
> Could not resolve all artifacts for configuration ':classpath'.                                                      
   > Could not find com.squareup.okhttp3:okhttp:.          
     Required by:                                          
         project : > com.mkobit.jenkins.pipelines.shared-library:com.mkobit.jenkins.pipelines.shared-library.gradle.plugin:0.9.0 > com.mkobit.jenkins.pipelines:jenkins-pipeline-shared-libraries-gradle-plugin:0.9.0     

Looks like a bug in Gradle

@mkobit mkobit added this to the 0.9.1 milestone May 28, 2019
@Jonatha1983
Copy link

Exactly what I was about to write you , thanks !

@mkobit mkobit self-assigned this May 28, 2019
@mkobit
Copy link
Owner Author

mkobit commented May 28, 2019

Plan is to reduce, reproduce, and report it to Gradle before fixing and releasing 0.9.1 today.

@Jonatha1983
Copy link

Jonatha1983 commented May 28, 2019

I think that part of the release flow should include the example repo upgrading to the candidate version and build + test with it , what do you think ? would you like me to help in this ?

@mkobit
Copy link
Owner Author

mkobit commented May 28, 2019

Reported upstream issue to Gradle at gradle/gradle#9565

Regarding #86 (comment) , I think that is a great idea.

In the past I've manually done this by

  • ./gradlew publishToMavenLocal in this repository with some version
  • Update the example to use mavenLocal() repository
  • Update plugin version to match locally published one
  • Run example build
  • Clean up local workspace to no longer use mavenLocal()
  • Go forward with actual version publication

I didn't do it this time, otherwise I would have caught this issue before publishing. It is a bit manual, which is probably why I didn't do it 😆 . I've thought about this a little before, and my hope would be that it is a part of the Circle CI pipeline to get automated feedback. I think some combination of composite builds with --include-build could be useful. I created #87 for tracking that.

@mkobit
Copy link
Owner Author

mkobit commented May 28, 2019

Released 0.9.1 and updated example in mkobit/jenkins-pipeline-shared-library-example@0cfeda9 - closing

@mkobit mkobit closed this as completed May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants