Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Saving draft: parsing From address: mail: invalid string #256

Open
ally9335 opened this issue Nov 25, 2024 · 2 comments
Open

Error: Saving draft: parsing From address: mail: invalid string #256

ally9335 opened this issue Nov 25, 2024 · 2 comments

Comments

@ally9335
Copy link

ally9335 commented Nov 25, 2024

I can't always replicate this: sometimes when a custom yet correct "From" is used:

name123 <something_custom@my_domain123.com>

there will arrise an JS alert, preventing me from sending an email:

Error: Saving draft: parsing From address: mail: invalid string

If I click "Close" or "Cancel", a "reply email" popup won't close. Even if I edit an email, an error will persist. Only reopening the browser tab will cure this.

Other times the same address won't cause any error, a message will get sent well.

What's the matter?

@mjl-
Copy link
Owner

mjl- commented Nov 28, 2024

If I click "Close" or "Cancel", a "reply email" popup won't close. Even if I edit an email, an error will persist. Only reopening the browser tab will cure this.

I've seen this happen too. Will investigate. For me it happened when sending a message while I had connectivity issues (i.e. I understood why it failed). Not sure why it would happen with a correct From address. If you've found any pattern in the mean time, or ways to reliably trigger this, let me know.

mjl- added a commit that referenced this issue Nov 28, 2024
…age failed

we kept the "save draft" promise, and would wait for it again for other
operations (eg close, save again, send), which wouldn't make progress.

can easily be reproduced by saving a message with a control character in an
address or the subject. saving the draft will fail.

for issue #256 by ally9335, thanks for reporting
@mjl-
Copy link
Owner

mjl- commented Nov 28, 2024

@ally9335 I think the commit just now fixes the issue. See https://www.xmox.nl/b/#ee48cf0dfd46a889ecf0a6dbf579912b9f95875d for a binary with this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants