-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 304 streamline tune #348
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pdate docs to reflect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I have edited the exisiting tune functions and added new tune functions so that
tune()
can now be used to both optimise number of variables to keep and also number of components to keep.tune()
functions now broadly have the following functionality:tune()
functions apart fromtune.spca()
andtune.rcc()
perf()
on this model (only exception istune.pca()
which just returns variance explained per component)tune.spca()
,tune.rcc()
,tune.spls()
,tune.splsda()
,tune.block.splsda()
andtune.block.plsda()
tune()
functionsList of current
tune()
functions and which functionalities they have:tune.pca()
- (1)tune.spca()
- (2)tune.rcc()
- (2)tune.plsda()
- (1)tune.splsda()
- (1) and (2)tune.pls()
- (1)tune.spls()
- (1) and (2)tune.block.plsda()
- (1)tune.block.splsda()
- (1) and (2)tune.mint.plsda()
- (1)tune.mint.splsda()
- (1) and (2)For the functions that have dual functionality, optimising components (1) can be done by setting
test.keepX = NULL
(and alsotest.keepY = NULL
fortune.spls()
. Iftest.keepX
is not NULL, functionality (2) is used.