Skip to content
This repository has been archived by the owner on Feb 11, 2022. It is now read-only.

Can we get a new release cut that includes the improvements in handling credentials? #475

Closed
dmcguire81 opened this issue Jun 27, 2016 · 3 comments
Milestone

Comments

@dmcguire81
Copy link

Specifically, this part of the README is out of date with the latest published version of the Gem (0.7.0):

Note: if you don't configure aws.access_key_id or aws_secret_access_key it will attempt to read credentials from environment variables first and then from $HOME/.aws/.

In the current published version, aws_profile is not recognized, and the credentials are not read from the environment variables.

@kenorb
Copy link

kenorb commented Jun 28, 2016

Ref: #441, #470, #151

@rtyler
Copy link
Collaborator

rtyler commented Jul 3, 2016

I'm tinkering this weekend with some recent changes. The problem with issues like this, and I don't mean to pick on you specifically @dmcguire81, is they kill any motivation I might have to work on a project. It makes it feel more like an obligation, than something fun.

I think it's generally better to ask "What can I do to help?" than "When will you do X?" (unless you're actually paying somebody for something of course)

@rtyler rtyler added this to the 0.7.1 milestone Jul 3, 2016
@rtyler rtyler closed this as completed Jul 3, 2016
@dmcguire81
Copy link
Author

@rtyler @kenorb Thanks for the quick turn-around time on this request! It helped me immensely with an issue that was a major inconvenience (specifically, having to build and host my own patch-version artifact for my team), so I hope that helps fill in some context.

Here were my assumptions when making this request:

  • It's trivial to implement (otherwise, I would have issued a PR, as is consistent with my Github history)
  • Only the project maintainer has the permissions to cut a release

Just so I'm abreast of proper etiquette for next time, which of those assumptions is incorrect, specifically?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants