Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence warning that venv does not exist #23

Closed
SteffenMuehle opened this issue Nov 24, 2024 · 4 comments · Fixed by #24
Closed

Silence warning that venv does not exist #23

SteffenMuehle opened this issue Nov 24, 2024 · 4 comments · Fixed by #24

Comments

@SteffenMuehle
Copy link

I work in a monorepo that has one .tool-versions file at its root and several subfolders that are Python projects with pyproject.tomls in them, all thus using the same tool-versions, which works fine.

However, when entering the repo in a new terminal, I get a one-time (once per terminal session) warning:
mise-poetry: Virtualenv does not exist at . Execute poetry install to create one. .

As I intentionally do not have a .venv in my repo root, I would like to silence this warning.
How can I do that?


.tool-versions file:

python 3.12.7
poetry 1.8.4

mise version:
2024.11.27 linux-x64 (5562f2f 2024-11-23)

OS:
Ubuntu 24.04.1 LTS

@gzurowski
Copy link

gzurowski commented Dec 3, 2024

I am seeing the same behavior on my end. A couple of recent changes introduces these error message, see the following initial issue for more context: #21

Is it possible to have Poetry defined as a global tool and not see these message @chris-lingwood-korelabs-co?

My global mise configuration has the following entry:

poetry = "latest"

@chris-lingwood-korelabs-co

The bug I fixed (at the second attempt I hope) was that auto install didn't work and it exited too soon so this code didn't run. By the sounds of it its exiting for the right reasons now, but the message is just...pointless.

Do you think the code path is wrong or that the message is just annoying?

I'd not disagree, but I really don't want to become the defactor maintainer of this and it sounds like its working as designed.

@gzurowski
Copy link

gzurowski commented Dec 5, 2024

I think the fix is fine, I am mainly referring to the annoying messages. Do you think we can remove these messages?

@chris-lingwood-korelabs-co

I don't see the rational for the message. Auto install is documented (and now works ;) ) and if you don't want that, being spammed isn't a good alternative. Devs will already know they need to run poetry install, thats how poetry works, its the normal state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants