Trikot analytics revamp #206
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npresseault
reviewed
Dec 6, 2023
| if (task.isSuccessful && result != null) { | ||
| continuation.resume(result) | ||
| } else if (!task.isSuccessful) { | ||
| continuation.cancel(Throwable(task.exception)) |
There was a problem hiding this comment.
Typed exceptions might help catching specific errors here.
also, why not resumeWithException
There was a problem hiding this comment.
+1 for .resumeWithException 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We deprecate the dependecy to trikot-streams with the following changes
fun distinctAppId(): Promise<String>and addsuspend fun distinctAppId(): StringAnalyticsService.trackEventandAnalyticsService. identifyUser, which uses publishers and replace them with functions that don't use publishers.TrackableViewModelAction, because it uses Publishers in its constructor in favour ofSimpleTrackableViewModelActionMotivation and Context
Newer projects should use Coroutines and flows, not trikot-streams.
How Has This Been Tested?
By running the trikot-viewmodels sample
Types of changes