Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 32bit? #71

Open
samoht opened this issue Jul 21, 2015 · 5 comments
Open

Support 32bit? #71

samoht opened this issue Jul 21, 2015 · 5 comments

Comments

@samoht
Copy link
Member

samoht commented Jul 21, 2015

Seems that the offset/length are currently int which limit the usability on 32bit architectures to 16MiB buffers. This is annoying, but changing offsets and lenght to int64 is a large API break that I would like to avoid.

So it might make sense to work with in64 internally, but keep the same signatures for len and offset, but expose len64 and offset64 which returns something valid (and make the normal function fail in case of overflow). Not sure if the runtime coast is worth the pain though ...

@cfcs
Copy link

cfcs commented Jun 3, 2018

@samoht Hmm, why does 32-bit ints limit it to 16MiB?

@dinosaure
Copy link
Member

dinosaure commented Jun 3, 2018

optint could be a solution to have an abstraction of integer independently from architecture.

@cfcs
Copy link

cfcs commented Jun 4, 2018

I guess - I still don't understand the issue though. What is it about the 31-bit int that limits things to 16MiB? Don't you still get 1GB of positive integers with the int type on 32bit?

@samoht
Copy link
Member Author

samoht commented Jun 4, 2018

@cfcs I have no idea anymore how I computed that 16 MiB limit ...

@cfcs
Copy link

cfcs commented Jun 4, 2018

Anyway, I always bid 63-bit lengths are welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants