Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

val buffer and val of_bigarray implement the same #311

Open
reynir opened this issue Feb 21, 2023 · 2 comments
Open

val buffer and val of_bigarray implement the same #311

reynir opened this issue Feb 21, 2023 · 2 comments

Comments

@reynir
Copy link
Member

reynir commented Feb 21, 2023

The two functions do exactly the same except for different messages in the Invalid_argument _ exception. It is not clear from the documentation.

Discovered while answering #310

@reynir
Copy link
Member Author

reynir commented Feb 21, 2023

It seems it was added in 6e82959#diff-1c794fc18075ec0a83c9f7b2ad768653e0ec3a60d60323e713d2f04d5b3c7c2aR82 while of_bigarray is much older.

@dinosaure
Copy link
Member

Yes, that's about me. I don't have a real opinion about that and I think the existence of both is fine. We probably should clarify the documentation and say that they do the same things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants