Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bc break] Remove "Selenium" dependency #46

Open
aik099 opened this issue Mar 20, 2015 · 0 comments
Open

[bc break] Remove "Selenium" dependency #46

aik099 opened this issue Mar 20, 2015 · 0 comments
Labels
type-enhancement

Comments

@aik099
Copy link
Member

aik099 commented Mar 20, 2015

Currently the Selenium dependency is hardcoded:

  • the selenium Mink driver is a requirement in composer.json
  • the timeout and desiredCapabilities settings in BrowserConfiguraiton only apply to Selenium

After #12 is implemented we can, but this will be BC break for sure:

  • replace selenium requirement in composer.json with suggest tag, that Mink itself uses
  • move desiredCapabilities and timeout from global BrowserConfiguration options to Selenium2 driver specific options
  • set empty default driver
  • upon attempt to create driver without actual driver name set throw an exception
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aik099