Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PHPUnit dependency from composer.json #45

Open
aik099 opened this issue Mar 16, 2015 · 1 comment
Open

Remove PHPUnit dependency from composer.json #45

aik099 opened this issue Mar 16, 2015 · 1 comment
Milestone

Comments

@aik099
Copy link
Member

aik099 commented Mar 16, 2015

Right now there a dependency on PHPUnit in composer.json which:

  • from one side is correct (library creates a test case class for PHPUnit)
  • from other side is not (it's forcing local PHPUnit copy in project even if PHPUnit is installed globally on machine and used from there)

@stof , can we just remove PHPUnit dependency?

@aik099 aik099 modified the milestone: 2.1.0 Mar 16, 2015
@stof
Copy link
Member

stof commented Mar 16, 2015

I would say yes (but documenting it). This would let everyone choose how they want to install PHPUnit (and they won't use this library if they don't use PHPUnit anyway).
This is the approach I took in https://github.com/phpspec/prophecy-phpunit btw

@aik099 aik099 modified the milestones: 2.1.0, 2.1.1 May 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants