Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding tests for "pressKey" #30

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

adding tests for "pressKey" #30

wants to merge 6 commits into from

Conversation

oleg-andreyev
Copy link
Contributor

adding tests for "pressKey"
minkphp/Mink#772

@oleg-andreyev oleg-andreyev mentioned this pull request Sep 2, 2019
Open
@aik099
Copy link
Member

aik099 commented Sep 2, 2019

Are you certain, that we don't have test coverage for pressKey method?

@oleg-andreyev oleg-andreyev mentioned this pull request Sep 2, 2019
Open
@oleg-andreyev
Copy link
Contributor Author

@aik099 pressKey is new method that I've added in minkphp/Mink#772 to be more W3C compatible, so other methods keyDown, keyPress and keyUp are marked as deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oleg-andreyev @aik099