Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle non-ascii characters in url #194

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Handle non-ascii characters in url #194

wants to merge 2 commits into from

Conversation

kolesar-andras
Copy link

Closes #193

@stof
Copy link
Member

stof commented Nov 22, 2021

I think the issue is the fact that the URL is injected into the evaluated JS code without properly escaping the string. Instead of using "$url", it should use $urlEscaped (without the double quotes around it), created as $urlEscaped = json_encode($url), as done in other methods of the driver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle non-ascii characters in url
2 participants
@kolesar-andras @stof