Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Facebook driver #304

Closed
wants to merge 66 commits into from
Closed

[WIP] Facebook driver #304

wants to merge 66 commits into from

Conversation

oleg-andreyev
Copy link
Contributor

@oleg-andreyev oleg-andreyev commented Jan 4, 2019 •
edited
Loading

This is work in progress

  • Moving away from instaclick/php-webdriver to facebook/php-webdriver as first one is not supported (Support the W3C webdriver spec #293 (comment))
  • Removing syn.js
  • Preparing to be more W3C compliant
  • We should release a new major version of Mink, because facebook/php-webdriver needs PHP >= 5.6

Depending on #303, php-webdriver/php-webdriver#621, minkphp/driver-testsuite#26, minkphp/driver-testsuite#25
Unblocks #298, #293
Closes #300
Closes #289
Closes #257
Closes #175
Closes #97

oleg-andreyev and others added 16 commits November 30, 2018 23:52
@oleg-andreyev
moved driver to facebook/webdriver
5be40f8
@oleg-andreyev
fixing initial commit
9921b40
@oleg-andreyev
added chrome to travis
34197e2
@oleg-andreyev
updated run-selenium.sh
ecd9e46
@oleg-andreyev
crlf to lf for bin, removed local override in phpunit.xml.dist, some …
305323d 
…fixes to Selenium2Driver.php
@oleg-andreyev
adjusted travis for chrome and ff
6666a62
@oleg-andreyev
fixing
3a988ef
@oleg-andreyev
fixing
4b97f28
@oleg-andreyev
fixing
ed49807
@oleg-andreyev
fixing upload & wait
2181be3
@oleg-andreyev
unskipping testWindowMaximize
d1cdddc
@oleg-andreyev
updated phpunit.xml.dist with examples for FF, updated Selenium2Confi…
e7ad036 
…g to support capability from phpunit.xml, updated setRequestHeader to support user-agent
@oleg-andreyev
downgrade firefox to 2.53.1
9dcf505
@oleg-andreyev
reverted "setRequestHeader", unified key actions
d84acc3
@oleg-andreyev
reverted tests/Custom
77c961f
@oleg-andreyev
added fix to getAttribute, added fix to setValue file-upload, fixing …
25a2d90 
…createDriver, added composer overrides (WIP)
@aik099
Copy link
Member

aik099 commented Jan 4, 2019

There are other closed PRs doing the same, that might help you:

aik099
aik099 requested changes Jan 4, 2019
View reviewed changes
composer.json Outdated Show resolved Hide resolved
composer.json Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
composer.json Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
@oleg-andreyev oleg-andreyev mentioned this pull request Jan 4, 2019
Merged
@oleg-andreyev
fixing travis build
ba7fad4 
- added docker for php >= 5.4 (trusty)
- added php 7.3
- updated README
- added DISPLAY env and xvfb for 5.3 (precise)
@oleg-andreyev
Merge branch 'fix-master-build' into facebook-driver
00cc9a8 
# Conflicts:
#	.travis.yml
@oleg-andreyev
added "getWebDriver" to bypass Mink API
127434f
@oleg-andreyev
changed visibility of executeJsOnXpath from protected to private
f0351a1
@oleg-andreyev
removed $started property in favor of isStarted, where we are checkin…
f6000fa 
…g $this->webDriver !== null;
@oleg-andreyev
avoid override $element variable in getValue/setValue
33d7e8f
@oleg-andreyev
removed comment from clickOnElement
eeeb1e1
@oleg-andreyev
removed typehint from attachFile, added correct return type to findEl…
5510e51 
…ement
@oleg-andreyev
changed exception in resizeWindow/maximizeWindow from generic Excepti…
4ba0fe5 
…on to UnsupportedDriverActionException
@oleg-andreyev
removed extra space in ensureInputType
eddbe48
@oleg-andreyev
removed unused method uploadFile
97827c0
@oleg-andreyev
updated docblock to keyModifier/decodeChar
d964481
@oleg-andreyev
updated docblock to wait method
ae01600
@oleg-andreyev
updated travis.yml
12209e5
@oleg-andreyev
changed implementation of focus/blur
c00efd4
@oleg-andreyev oleg-andreyev mentioned this pull request Jan 8, 2019
Open
@oleg-andreyev
Copy link
Contributor Author

@stof build is again green. I'll start working on deprecating keyUp/keyPress/keyDown in favor of pressKey as per discussion #304 (comment)

@stof
Copy link
Member

stof commented Jan 11, 2019

@oleg-andreyev please do that in separate PRs, so that it can be applied to the existing driver too.

@oleg-andreyev
Copy link
Contributor Author

Meanwhile can you create “webdriver” repository under minkphp for new driver, thanks

@oleg-andreyev oleg-andreyev mentioned this pull request Jan 13, 2019
Open
@individual-it individual-it mentioned this pull request Feb 15, 2019
Open
@reinholdfuereder reinholdfuereder mentioned this pull request Mar 20, 2019
Closed
@oleg-andreyev
Copy link
Contributor Author

I'm moving my effort to https://github.com/oleg-andreyev/MinkFacebookWebDriver

@oleg-andreyev oleg-andreyev mentioned this pull request Jun 17, 2020
Closed
@oleg-andreyev oleg-andreyev mentioned this pull request Oct 12, 2021
Merged
@oleg-andreyev oleg-andreyev mentioned this pull request Jun 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof requested changes

@aik099 aik099 aik099 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@oleg-andreyev @aik099 @stof