-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Deno and cloudflare workers deploy #1265
base: master
Are you sure you want to change the base?
Conversation
A Pr will be done also in submodules |
… and cloudflare worker
I also had to replace stream-json for the same reason, alternative was recommended here: uhop/stream-json#91 |
Last require change: That led me to make the big change you see in the last commit. |
It would be awesome to prioritize this to make it work on Cloudflare workers. |
As I reported here: #1261
There is some issue in Deno and also in Cloudflare workers to deploy.
I used a hack with ESM to deploy, but found out the only problem was the Babel config.
The good part is it's easy to fix, since it's already stated in
package.json
that the min version to use the package is Node.js 16.The
node:
was introduced in Node.js 16.Since then, it also got back ported to Node.js 14 and Node.js 12, but I followed what was set in
package.json
and aligned the test to run only from 16.I also updated the lint step to run on the latest LTS, that is optional I can remove it if required.
Link: who talks about supported version: https://2ality.com/2021/12/node-protocol-imports.html
Node.js doc: https://nodejs.org/api/esm.html#node-imports