Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add api to enableVirtualStyleEndpoint #1065

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

warjiang
Copy link
Contributor

@warjiang warjiang commented Sep 5, 2022

New to use aliyun oss. With ak\sk\endpoint, the aliyun oss server always response with error: SecondLevelDomainForbidden。I need to add api to support virtual_style_endpoint like minio python sdk.
image

if without this api, developer must specify pathStyle=false when init minio client, and this api is ambiguous.
image

with this api, it's will be clear for developer
image

@warjiang
Copy link
Contributor Author

warjiang commented Nov 3, 2022

can anyone help me, make pr merged or give me other suggestion?

@prakashsvmx
Copy link
Member

@warjiang thank you for the contribution.

may be you could check #854 which was similar it was closed as there was no activity.

@warjiang
Copy link
Contributor Author

warjiang commented Nov 8, 2022

@prakashsvmx
as mentioned in #854 , it's not a good way to list all cloud storage provider such as amazon or aliyun, expose virtual path style setting to developer takes more compatibility as more and more cloud storage provider enable virutal path style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants