Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submodules #3

Open
RealBadAngel opened this issue Jul 19, 2013 · 6 comments
Open

Submodules #3

RealBadAngel opened this issue Jul 19, 2013 · 6 comments

Comments

@RealBadAngel
Copy link
Member

Im not sure if submodules are good solution for technic_game...
Because:

  • theres no simple way to download game pack. ZIP link doesnt work anymore in place of used mods there are empty inventories. KISS idea for newbies to easily get the game - R.I.P.
  • submodules are not updating. I just pushed commit to technic and git doesnt see the changes made in this submodule
  • game was supposed to use x32 textures for all the mods, theres no way to achieve that now

I liked the idea of using them, but now it seems that it is not usable in this case.

@ShadowNinja
Copy link
Member

  1. GitHub currently doesn't support recursing into submodules. You will have to make your own zips.
  2. Submodules only update if you explicitly update them. This prevents new commits to the sub-project from breaking the super-project for example.
  3. You could distribute 32x texture pack seperately, this would allow users to use the texture pack without the game.

@RealBadAngel
Copy link
Member Author

I just want technic_game to be single download with all the additions, new textures.
Just to be complete replacement for minetest_game.
With submodules it is not a replacement.Its hardcore, almost impossible to get it for newbies.

@RealBadAngel
Copy link
Member Author

Also this way its impossible for us to make changes in mods we are using.

@ShadowNinja
Copy link
Member

It is easier, instead of doing every commit twice you just commit once and update the game every once in a while.

@RealBadAngel
Copy link
Member Author

I do really appreciate your work, but in this very case i have to revert those changes, please forgive me.
I want to keep this particular repo KISS for newbies.
We are hardocore coders, we can deal with many things, but folks outside wont be able to.
Look at comments in game topic...
I am aware of this i will have to update mods manually, but thats the price i agreed to pay for others to get better, polished and easy to get product.
Please do not get this as an attack on your code, you have certainly spent your time on this commit. I believe we can use knowledge you got somwhere else. Maybe indev version of game?
That could make sense, gather all the mods in indev, add the changes and push to the master.
I can do all the manual changes, textures etc.

@sdzen
Copy link

sdzen commented Aug 6, 2013

I need to get back to texturing for this, I left you alone with it too long!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants