Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema for Validation Purposes and led-board-manager integration #26

Open
sflems opened this issue May 25, 2021 · 0 comments
Open

Schema for Validation Purposes and led-board-manager integration #26

sflems opened this issue May 25, 2021 · 0 comments

Comments

@sflems
Copy link

sflems commented May 25, 2021

Is your feature request related to a problem? Please describe.
No. This could enhance validation and board management for users.

Describe the solution you'd like
Schema file would define required config.json settings with NFL board settings. Could be expanded to validate similar to NHL board.

Describe alternatives you've considered
Schema could be provided with led-board-manager. Adding to NFL project would make it available for validators and as a reference for the config.json.

Additional context
I've generated a schema for the config that would allow easy integration to manage boards and generate config forms in the led-board-manager app. This does not affect the core in any way and future features added to this schema would dynamically update any added validation as well as user forms for config generation/validation and hot-swapping boards.

No harm no foul if you'd like to exclude it. Or let me know, and I could look into adding config validation. See also PR #25.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant