Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate spring-cloud-dependencies #165

Open
cedbesafilm opened this issue Dec 9, 2020 · 2 comments
Open

Duplicate spring-cloud-dependencies #165

cedbesafilm opened this issue Dec 9, 2020 · 2 comments
Assignees
Labels
Milestone

Comments

@cedbesafilm
Copy link

The function Add starters... add another reference in dependencyManagement

For example, first i create a pom with only Eureka Server and after i add Sleuth and Sleuth Zipkin

This is the result (left before and right after the commit)
image

The project compile and run but maven send me warning about it
image

@Eskibear Eskibear added the bug label Dec 10, 2020
@Eskibear Eskibear self-assigned this Dec 10, 2020
@deekshithanand
Copy link

I get a similar issue, Everytime I add a spring cloud related starter for my pom, ex cloud config, spring vault, etc, The below mentioned snippet gets adding again and again.

<dependencyManagement>
		<dependencies>
			<dependency>
				<groupId>org.springframework.cloud</groupId>
				<artifactId>spring-cloud-dependencies</artifactId>
				<version>2021.0.0</version>
				<type>pom</type>
				<scope>import</scope>
			</dependency>
		</dependencies>
	</dependencyManagement>

@Eskibear
Copy link
Member

Eskibear commented Feb 9, 2022

"boms": {
        "spring-cloud": {
            "groupId": "org.springframework.cloud",
            "artifactId": "spring-cloud-dependencies",
            "version": "2021.0.0",
            "repositories": []
        },

It's appending corresponding BOM when you add any "spring-cloud" starter. A potential fix would be: only to insert the BOM node when it doesn't exists in pom.xml.

@Eskibear Eskibear added this to the Backlog milestone Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants