Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project wide evaluation #79

Open
timeterror opened this issue May 4, 2022 · 3 comments
Open

Project wide evaluation #79

timeterror opened this issue May 4, 2022 · 3 comments
Labels
feature-request Request for new features or functionality needs community feedback

Comments

@timeterror
Copy link

Pylint can evaluate code across a folder and subfolders, which provides insights into issues such as duplicate code. Being able to trigger pylint on a folder can provide users with a unique feature not available in the built-in linting of the vscode python extension. Additionally, users could apply this to gain insights into a project's general code quality, preferably by means of pylint's scoring feature.

@github-actions github-actions bot added the triage-needed Issue is not triaged. label May 4, 2022
@karthiknadig karthiknadig added feature-request Request for new features or functionality needs community feedback and removed triage-needed Issue is not triaged. labels May 4, 2022
@alkatar21
Copy link

alkatar21 commented May 6, 2022

I would also find it cool if you could either do folder or maybe just workspace linting.
Currently I sometimes use "python.analysis.diagnosticMode": "workspace", which I think is really slow because each file is fed individually to pylint and so some analysis like duplicate code still doesn't work.
Edit: I'm not sure if I had that wrong in my head at the time, or if it just doesn't work anymore? Only current files are analyzed.
One option I could think of would be a command that somehow lets pylint analyze the workspace?

@alkatar21
Copy link

I seem to have imagined it, but apparently pylint in the python extension did not react to "python.analysis.diagnosticMode": "workspace", either and then processed all files. At least I can't reproduce it right now with an older python extension version either. But it would be cool if there would be the possibility to let pylint analyze all files in the workspace and see them in the Problems View.

@AviSarmani
Copy link

I would love to see it as well.
Especially considering that it works that way when we install pylint manually.
The whole purpose of the extension(from my standpoint) was that the extension takes care of the installation and periodic update of pylint without the need to ask every developer to update to the latest version
A simple scenario would be:

  • The developer writes some code with an error/warning but closes the file for some reason
  • The day after pushes the code(as he/she forgot about the error/warning) and the CI fails
  • Asking them to run it manually each time defeats the purpose
    And again, if pylint is already installed and "python.analysis.diagnosticMode": "workspace" on his local machine, this wouldn't be an issue

Please consider implementing this
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality needs community feedback
Projects
None yet
Development

No branches or pull requests

4 participants