Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Sign in to Directory..." shows in Azure Resources view after signing in with MSAL #935

Open
v-ruizh opened this issue Oct 9, 2024 · 2 comments
Labels
AT-CTI Created by CTI team 🐛bug Something isn't working

Comments

@v-ruizh
Copy link

v-ruizh commented Oct 9, 2024

OS: All
Build Version: 20241004.1
Regression: Not a regression

Repro Steps:

  1. Enable the setting "Microsoft: Use Msal".
    Image
  2. Click "Sign in to Azure..." in Azure Resources view and sign in with Azure Account.
  3. Check whether the subscriptions are listed in Azure Resources view.

Expect:
The subscriptions are listed in Azure Resources view.

Actual:
"Sign in to Directory..." shows in Azure Resources view.
Image

More Info:

  1. This issue does not reproduce if the setting "Microsoft: Use Msal" is disabled.
  2. Click "Sign in to Directory..." to sign in again, the subscriptions will be listed.
@v-ruizh v-ruizh added the AT-CTI Created by CTI team label Oct 9, 2024
@alexweininger
Copy link
Member

We think this is due to a recent change in VS Code. Which version of VS Code are you using to reproduce this issue? Could you try reverting versions until it doesn't reproduce?

@alexweininger alexweininger added the 🐛bug Something isn't working label Oct 9, 2024
@v-ruizh
Copy link
Author

v-ruizh commented Oct 10, 2024

@alexweininger We use the latest VS Code "1.94.1" to reproduce this issue. Verified the previous VS Code "1.93.1", this issue also reproduces in this VS Code. This may be caused by the setting "Microsoft: Use Msal" was added from VS Code "1.93.1", this issue will reproduce if enable this setting to sign in.
Image

There is no setting "Microsoft: Use Msal" in VS Code "1.92.2", so this issue does not reproduce in VS Code "1.92.2".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AT-CTI Created by CTI team 🐛bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants