Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[materialx] Fix usage error #42344

Merged
merged 4 commits into from
Nov 28, 2024
Merged

Conversation

jimwang118
Copy link
Contributor

Fix the following error:

CMake Error at E:/usd/installed/x64-windows/share/MaterialX/MaterialXConfig.cmake:19 (message):
  File or directory E:/usd/installed/x64-windows/resources referenced by
  variable MATERIALX_RESOURCES_DIR does not exist !

Disable the MATERIALX_BUILD_RENDER property to not compile MaterialX Render modules.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Usage test passed with x64-windows triplet.

@jimwang118 jimwang118 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Nov 25, 2024
@dg0yt
Copy link
Contributor

dg0yt commented Nov 25, 2024

Okay...
First the resources are installed by the package.
Then the installed resources are removed by the portfile.
Then the usage fails.
Then vcpkg maintainers decide "to not compile MaterialX Render modules". 😕

@jimwang118
Copy link
Contributor Author

Okay... First the resources are installed by the package. Then the installed resources are removed by the portfile. Then the usage fails. Then vcpkg maintainers decide "to not compile MaterialX Render modules". 😕

The error fix has been deleted and re-applied.

@jimwang118 jimwang118 marked this pull request as ready for review November 26, 2024 06:14
@BillyONeal BillyONeal merged commit dbdc9b3 into microsoft:master Nov 28, 2024
17 checks passed
@jimwang118 jimwang118 deleted the fix-materialx branch November 28, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants