Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skewed vertical box lines displayed in Far Manager #18247

Open
vblazhkun opened this issue Nov 25, 2024 · 10 comments
Open

Skewed vertical box lines displayed in Far Manager #18247

vblazhkun opened this issue Nov 25, 2024 · 10 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting

Comments

@vblazhkun
Copy link

vblazhkun commented Nov 25, 2024

Windows Terminal version

1.22.3232.0

Windows build number

10.0.19045.0

Other Software

Far Manager 3.0.6364.0 x64

Steps to reproduce

Open a directory in the left panel of Far Manager with some Russian-named files there.

Expected Behavior

No skewed surrounding boxes displayed anywhere.

An example from conhost.exe:

Image

Actual Behavior

On the rows where the Russian-named files are, the vertical box drawing lines are shifted left. The characters used to draw the given lines are Unicode Box Drawings Double Vertical encoded as U+2551.

Example:

Image

NOTE: I have not seen that issue in the previous versions (e.g. 1.21.3231.0) of the Terminal. It might be related to some new setting introduced in the Preview release, but I am not sure.

@vblazhkun vblazhkun added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Nov 25, 2024
@DHowett
Copy link
Member

DHowett commented Nov 25, 2024

Would you be able to capture a screenshot that covers the entire width of the window where the corruption exists?

@vblazhkun
Copy link
Author

The entire screen as requested:

Image

Also I do not see the issue with Midnight Commander running under WSL with the same directory and box drawing characters:

Image

@DHowett
Copy link
Member

DHowett commented Nov 25, 2024

Image

This is highly unusual. Two files with the same display name?

Is there a chance you have decomposed and composed character versions of the same filename in that folder?

Decomposed (or composed, I guess) characters will have different measurement outcomes on 1.22+.

@vblazhkun
Copy link
Author

Image

This is highly unusual. Two files with the same display name?

Is there a chance you have decomposed and composed character versions of the same filename in that folder?

Decomposed (or composed, I guess) characters will have different measurement outcomes on 1.22+.

The filenames are actually different (see the attached hex dump):

Image

  1. d0 93 d1 80 d1 83 d0 bf d0 bf d0 be d0 b2 d0 b0 d1 8f 20 d0 bf d0 b5 d1 87 d0 b0 d1 82 d1 8c 20 d0 b2 d1 8b d0 b1 d1 80 d0 b0 d0 bd d0 bd d1 8b d1 85 20 d0 b7 d0 b0 d0 bf d0 b8 d1 81 d0 b5 d0 b8 cc 86 31 20 28 31 29 2e 70 64 66 0a
  2. d0 93 d1 80 d1 83 d0 bf d0 bf d0 be d0 b2 d0 b0 d1 8f 20 d0 bf d0 b5 d1 87 d0 b0 d1 82 d1 8c 20 d0 b2 d1 8b d0 b1 d1 80 d0 b0 d0 bd d0 bd d1 8b d1 85 20 d0 b7 d0 b0 d0 bf d0 b8 d1 81 d0 b5 d0 b9 31 20 28 31 29 2e 70 64 66 0a

@vblazhkun
Copy link
Author

vblazhkun commented Nov 25, 2024

And the diff:

Image

Looks like the letter й issue. It can be composed as a single character and as a double character (diacritical) as well: и + U+0306.

@o-sdn-o
Copy link

o-sdn-o commented Nov 25, 2024

@vblazhkun
Copy link
Author

vblazhkun commented Nov 25, 2024

Another observation: U+0306 somehow eats the space on the right and the space pops-up when I add any character on the left:

Image

@Zeroes1
Copy link

Zeroes1 commented Nov 25, 2024

@o-sdn-o Far Manager don't support grapheme now (it's may be later)

@vblazhkun Я надеюсь у вас выставлена эта опция в настройках? ( в вашей версии это в разделе Отрисовка)

Image

В настройках Совместимости или Отрисовки
Режим измерения текста должен быть изменён
Кластеры Grapheme -> консоль Windows
в settings.json
за это отвечает строка:
"compatibility.textMeasurement": "console",

пока не появится поддержка графем в FAR'e

@DHowett It's possible force set English lang interface of WT? not get from regional settins from OS?

@DHowett
Copy link
Member

DHowett commented Nov 26, 2024

@DHowett It's possible force set English lang interface of WT? not get from regional settins from OS?

Yes. It is in the Appearance page if you are using the MSIX version.

@Zeroes1
Copy link

Zeroes1 commented Nov 26, 2024

@DHowett need close ticket? It's only Far Manager issue. There is a current solution to the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting
Projects
None yet
Development

No branches or pull requests

4 participants