Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Terminal Chat Setup] App link like ms-terminal-can://... doesn't launch Terminal #18158

Open
dmealo opened this issue Nov 6, 2024 · 7 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting

Comments

@dmealo
Copy link

dmealo commented Nov 6, 2024

Windows Terminal version

1.23.3091.0, 1.23.3101.0

Windows build number

10.0.22631.0

Other Software

No response

Steps to reproduce

  1. Launch Settings
  2. Navigate to Terminal Chat (Experimental)
  3. Expand GitHub Copilot under Service Providers
  4. Click Authenticate via GitHub
  5. Authenticate and approve access to GitHub account in browser
  6. Click "Open Terminal Canary" in resulting browser modal dialog

Expected Behavior

Windows Terminal Canary should launch and receive the auth token from GitHub to complete GitHub Copilot setup for Terminal Chat.

Actual Behavior

Windows Terminal Canary does not launch. This does not work from the default browser (Chrome) nor from Edge.

@dmealo dmealo added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Nov 6, 2024
@dmealo dmealo changed the title App link like ms-terminal-can://... doesn't launch Terminal [Terminal Chat Setup] App link like ms-terminal-can://... doesn't launch Terminal Nov 6, 2024
@radrad
Copy link

radrad commented Nov 9, 2024

The same for me. It looks like Windows Terminal Canary is not registered to handle ms-terminal-can://...

I am on windows 10

@carlos-zamora
Copy link
Member

Thanks for filing! Could you share what's in the OS's Settings app under "Apps" > "Default apps" > "Choose defaults by link type" /?
It may be different on windows 10, but it should exist though.

We're expecting it to look something like this:
Image

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Nov 13, 2024
@tino-github
Copy link

I have the settings just like it shows in the screenshot:
Image

However, the terminal does not get launched.

@Zheke32174
Copy link

Zheke32174 commented Nov 15, 2024

I am having the same issue. I can not find any solution online. I am on windows 11 24h2. I find this especially confusing because GH auth redirects back to the terminal from the browser but copilot does not.

@jvcosmo
Copy link

jvcosmo commented Nov 18, 2024

I'm unable to login to use Github Copilot because of that problem. Even registered, the browser doesn't redirect to terminal canary.

@microsoft-github-policy-service microsoft-github-policy-service bot added the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label Nov 22, 2024
@dmealo
Copy link
Author

dmealo commented Nov 22, 2024

My settings are as @tino-github ’s, please do not close.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. labels Nov 22, 2024
@lly-c232733
Copy link

same issue for me. cannot use copilot cli because of this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting
Projects
None yet
Development

No branches or pull requests

7 participants