Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add async calls to (Azure) OpenAI #97

Open
ianchi opened this issue Oct 8, 2024 · 3 comments
Open

Add async calls to (Azure) OpenAI #97

ianchi opened this issue Oct 8, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@ianchi
Copy link
Contributor

ianchi commented Oct 8, 2024

Current Invoke does not allow for async calls to OpenAI api.

This is a blocker for adoption where non blocking use is needed (or unelegant hacks needs to be added on top).

The proposal is to add an ainvoke interfase, that works with the same inputs and resolves to the same outputs.

@sethjuarez
Copy link
Member

Good call - I need to do that.

@sethjuarez sethjuarez self-assigned this Oct 11, 2024
@sethjuarez sethjuarez added the enhancement New feature or request label Oct 11, 2024
@ianchi
Copy link
Contributor Author

ianchi commented Oct 12, 2024

Hi @sethjuarez, I see that it is already implemented in promptflow.core

In fact all Prompty implementation is more complete there. (Escaping, handling of tools in parser, streaming, token count)

Is there a plan to unify the base parsing?

@sethjuarez
Copy link
Member

Tool handling, streaming, and token count already work in prompty (if it reports tokens of course). I do agree that I need to add async invokers. Give me a couple of days to get it in (some folks are also working on json_schema enhancements).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants