Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build][Nuget] Microsoft.AI.MachineLearning.dll is not copied to the output folder. #22939

Open
mrzade opened this issue Nov 25, 2024 · 3 comments
Assignees
Labels
api:CSharp issues related to the C# API build build issues; typically submitted using template .NET Pull requests that update .net code

Comments

@mrzade
Copy link

mrzade commented Nov 25, 2024

Describe the issue

Microsoft.AI.MachineLearning.dll is not copied to the output folder when compiling native C++/WinRT projects.
Nuget package version 1.20.1.

Urgency

No response

Target platform

Windows x64

Build script

There is no custom one. Only Nuget's .props/.targets are involved.

Error / output

The condition in csharp/src/Microsoft.AI.MachineLearning/Microsoft.AI.MachineLearning.targets, line 35 seems to be broken since 1.16.0:

<ItemGroup Condition="'$(NuGetProjectStyle)' != 'PackageReference' AND WinAppSDKPackageName == ''">

Shouldn't the WinAppSDKPackageName be an MSBuild variable?
Also, the Microsoft.AI.MachineLearning NuGet Settings rule never pops up in the project settings UI, but this is probably unrelated.

Visual Studio Version

17.9.6

GCC / Compiler Version

No response

@mrzade mrzade added the build build issues; typically submitted using template label Nov 25, 2024
@github-actions github-actions bot added .NET Pull requests that update .net code api:CSharp issues related to the C# API labels Nov 25, 2024
@skottmckay
Copy link
Contributor

Generally the C# packages are built via the CI using https://github.com/microsoft/onnxruntime/blob/main/csharp/OnnxRuntime.CSharp.proj.

What's the use-case where you need to build it locally?

@mrzade
Copy link
Author

mrzade commented Nov 26, 2024

I'm not building the Nugets. I'm consuming them in the native C++/WinRT project.

@skottmckay
Copy link
Contributor

@smk2007 Is this meant to be $(WinAppSDKPackageName)?

Also want to check that property name. I can't find any other reference to WinAppSDKPackageName in an internet search or the ORT codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api:CSharp issues related to the C# API build build issues; typically submitted using template .NET Pull requests that update .net code
Projects
None yet
Development

No branches or pull requests

3 participants