Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: DRIFT not configurable #1432

Open
3 tasks done
MBRSL opened this issue Nov 22, 2024 · 0 comments
Open
3 tasks done

[Bug]: DRIFT not configurable #1432

MBRSL opened this issue Nov 22, 2024 · 0 comments
Labels
bug Something isn't working triage Default label assignment, indicates new issue needs reviewed by a maintainer

Comments

@MBRSL
Copy link

MBRSL commented Nov 22, 2024

Do you need to file an issue?

  • I have searched the existing issues and this bug is not already filed.
  • My model is hosted on OpenAI or Azure. If not, please look at the "model providers" issue and don't file a new one here.
  • I believe this is a legitimate bug, not just a question. If this is a question, please use the Discussions area.

Describe the bug

Though a various parameters can be set through setting.yml, it's not working for DRIFT. For example, I wish to set lower follow ups by using:

...
drift_search:
  drift_k_followups: 1

This isn't working since DRIFTSeach doesn't read config (see below).
https://github.com/microsoft/graphrag/blob/v0.5.0/graphrag/query/factories.py#L193

DRIFTSearchContextBuilder reads from config but DRIFTSeach doesn't.

Steps to reproduce

Step 1: Init graphrag with arbitary documents
Step 2: Modify setting.yml. Add drift_k_followups like the followings

drift_search:
  drift_k_followups: 1

Step 3: Index
Step 4: Ask random questions with drift search

Expected Behavior

Expected:
In the console output, it should output 5/5 in the first phase and 1/1 in the second phase

Actual:
In the console output, it output 5/5 in the first phase and 20/20 in the second phase

GraphRAG Config Used

No response

Logs and screenshots

No response

Additional Information

  • GraphRAG Version: 0.5.0
  • Operating System: Mac OS 14.4.1
  • Python Version: 3.11.9
@MBRSL MBRSL added bug Something isn't working triage Default label assignment, indicates new issue needs reviewed by a maintainer labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Default label assignment, indicates new issue needs reviewed by a maintainer
Projects
None yet
Development

No branches or pull requests

1 participant