Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue]: Local search notebook example rendering is broken #1412

Open
3 tasks
rhamnett opened this issue Nov 15, 2024 · 0 comments
Open
3 tasks

[Issue]: Local search notebook example rendering is broken #1412

rhamnett opened this issue Nov 15, 2024 · 0 comments
Labels
triage Default label assignment, indicates new issue needs reviewed by a maintainer

Comments

@rhamnett
Copy link

rhamnett commented Nov 15, 2024

Do you need to file an issue?

  • I have searched the existing issues and this bug is not already filed.
  • My model is hosted on OpenAI or Azure. If not, please look at the "model providers" issue and don't file a new one here.
  • I believe this is a legitimate bug, not just a question. If this is a question, please use the Discussions area.

Describe the issue

The documentation page at https://microsoft.github.io/graphrag/examples_notebooks/local_search/ is broken.

Presumably the cells are dynamically processed in the notebook to generate the documentation. Cells 17 and 21 error out.

I was looking for examples of "question generation"

eg of broken cell

---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
Cell In[21], line 5
      1 question_history = [
      2     "Tell me about Agent Mercer",
      3     "What happens in Dulce military base?",
      4 ]
----> 5 candidate_questions = await question_generator.agenerate(
      6     question_history=question_history, context_data=None, question_count=5
      7 )
      8 print(candidate_questions.response)

File ~/work/graphrag/graphrag/graphrag/query/question_gen/local_gen.py:74, in LocalQuestionGen.agenerate(self, question_history, context_data, question_count, **kwargs)
     70     conversation_history = ConversationHistory.from_list(history)
     72 if context_data is None:
     73     # generate context data based on the question history
---> 74     context_data, context_records = self.context_builder.build_context(
     75         query=question_text,
     76         conversation_history=conversation_history,
     77         **kwargs,
     78         **self.context_builder_params,
     79     )  # type: ignore
     80 else:
     81     context_records = {"context_data": context_data}

TypeError: cannot unpack non-iterable ContextBuilderResult object

Steps to reproduce

No response

GraphRAG Config Used

# Paste your config here

Logs and screenshots

No response

Additional Information

  • GraphRAG Version:
  • Operating System:
  • Python Version:
  • Related Issues:
@rhamnett rhamnett added the triage Default label assignment, indicates new issue needs reviewed by a maintainer label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Default label assignment, indicates new issue needs reviewed by a maintainer
Projects
None yet
Development

No branches or pull requests

1 participant