Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CONFIG_BPF_JIT_DISABLED code into its own file to reduce the amount of #ifdef #3895

Open
Alan-Jowett opened this issue Oct 2, 2024 · 1 comment
Open

Refactor CONFIG_BPF_JIT_DISABLED code into its own file to reduce the amount of #ifdef #3895

Alan-Jowett opened this issue Oct 2, 2024 · 1 comment
Assignees
@vpidatala94
Labels
cleanup Affects API usability or code maintainability but not correctness or applicability P3 triaged Discussed in a triage meeting
Milestone
2502

Comments

@Alan-Jowett
Copy link
Member

The codebase has quite a few #if defined(CONFIG_BPF_JIT_DISABLED) blocks throughout the code. It would make more sense to refactor the code to split scenario specific code into its own file and make the mainline code more readable.
@Alan-Jowett Alan-Jowett mentioned this issue Oct 2, 2024
Merged
@dthaler dthaler added the cleanup Affects API usability or code maintainability but not correctness or applicability label Oct 2, 2024
@dthaler dthaler changed the title Refactor CONFIG_BPF_JIT_DISABLED code into it's own file to reduce the amount of #ifdef Refactor CONFIG_BPF_JIT_DISABLED code into its own file to reduce the amount of #ifdef Oct 7, 2024
@shankarseal shankarseal added triaged Discussed in a triage meeting P3 labels Oct 7, 2024
@shankarseal shankarseal added this to the 2501 milestone Oct 7, 2024
@shankarseal
Copy link
Collaborator

Refactor source into different files for JIT v Native.

@shankarseal shankarseal modified the milestones: 2501, 2502 Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vpidatala94 vpidatala94

Labels
cleanup Affects API usability or code maintainability but not correctness or applicability P3 triaged Discussed in a triage meeting
Projects
None yet
Milestone
2502
Development

No branches or pull requests
4 participants
@dthaler @Alan-Jowett @shankarseal @vpidatala94