Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement remove_subscription in worker runtime #4357

Open
peterychang opened this issue Nov 25, 2024 · 2 comments
Open

Implement remove_subscription in worker runtime #4357

peterychang opened this issue Nov 25, 2024 · 2 comments
Assignees
Labels
Milestone

Comments

@peterychang
Copy link
Collaborator

Worker runtime currently does not support subscription removal. This feature is needed for the updated direct messaging method used for multi-process workflows. Specifically, agents sending RPC messages to other agents will need to unsubscribe from the response channel once a response has been received

@peterychang peterychang added this to the 0.4.1 milestone Nov 25, 2024
@peterychang peterychang self-assigned this Nov 25, 2024
@rysweet rysweet self-assigned this Nov 25, 2024
@MohMaz
Copy link
Contributor

MohMaz commented Nov 26, 2024

@rysweet for the x-lang issues, is the scope of the issue to address it in both python and .net ? or should I try to break these into two issues?

@rysweet
Copy link
Collaborator

rysweet commented Nov 26, 2024

the apis will need work on both sides:

  • make .proto updates for RemoveSubscriptionRequest/Response
  • add handlers to run/read loop of .NET AgentWorker and GrpcGateway
  • add methods to AgentBase in each side to call those apis
  • In python add handlers to work when its python only

@fniedtner fniedtner assigned jackgerrits and unassigned peterychang Nov 26, 2024
@jackgerrits jackgerrits removed their assignment Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants