Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Simplify exported projects #32

Open
2 of 4 tasks
nmetulev opened this issue Nov 25, 2024 · 0 comments
Open
2 of 4 tasks

[FEATURE] Simplify exported projects #32

nmetulev opened this issue Nov 25, 2024 · 0 comments

Comments

@nmetulev
Copy link
Member

Is your feature request related to a problem? Please describe.
The exported projects for each sample contain too much of the gallery shell and should be simplified even further to optimize for simplicity and getting started. The current papercuts of the exported projects are:

  • The page to the sample is in a different file than the MainWindow where I would expect it. The file is also named differently for each sample, making it difficult to find exactly which one it is
  • The actual configuration of the sample is all contained in the SampleNavigationParameters.cs and that is not intuitive
  • Namespaces for projects are different making it harder to mix samples together

Describe the solution you'd like
We should change how the samples are exported by:

  • We should remove the SampleNavigationParameters and inject the values in the MainWIndow class as properties, or directly in the OnNavigatedTo method
  • We should replace SampleNavigationParameter.RequestWaitForCompletion and SampleNavigationParameter.NotifyCompletion with code to show the injected loading view. We can pattern match the line if (e.Parameter is SampleNavigationParameters sampleParam) to identify the name of the parameter and replace usage accordingly.
  • Helper classes should be in a separate folder to make it easy to identify the entry point to the sample (MainWindow)
  • Make the root namespace the same for all projects. AIDevGallery.Sample and AIDevGallery.Sample.Utils
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant