-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DTO joins support issues #2761
Draft
radovanradic
wants to merge
10
commits into
4.10.x
Choose a base branch
from
dto-support-issues
base: 4.10.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
DTO joins support issues #2761
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
37fa871
DTO joins support issues
radovanradic b7c27ca
Check if entity and DTO field types are compatible
radovanradic c526c08
Fix DTO many to one relation in jdbc
radovanradic 9790cf9
Merge branch 'master' of https://github.com/micronaut-projects/micron…
radovanradic 78d0df4
Sonar and coverage issues
radovanradic 3fee2bc
Ignore Sonar error suggesting using instanceOf
radovanradic d3744c0
Address CR comments
radovanradic e7a0a4a
Added since
radovanradic 37da946
Merge branch 'master' of https://github.com/micronaut-projects/micron…
radovanradic a8c0ce5
Merge branch '4.10.x' into dto-support-issues
radovanradic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70 changes: 70 additions & 0 deletions
70
data-tck/src/main/java/io/micronaut/data/tck/entities/BookDtoWithAuthorDto.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
/* | ||
* Copyright 2017-2020 original authors | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package io.micronaut.data.tck.entities; | ||
|
||
import io.micronaut.core.annotation.Introspected; | ||
|
||
import java.time.LocalDateTime; | ||
|
||
@Introspected | ||
public class BookDtoWithAuthorDto { | ||
|
||
private String title; | ||
private int totalPages; | ||
private LocalDateTime lastUpdated; | ||
|
||
private AuthorDTO author; | ||
|
||
public BookDtoWithAuthorDto() { | ||
} | ||
|
||
public BookDtoWithAuthorDto(String title, int totalPages) { | ||
this.title = title; | ||
this.totalPages = totalPages; | ||
} | ||
|
||
public String getTitle() { | ||
return title; | ||
} | ||
|
||
public void setTitle(String title) { | ||
this.title = title; | ||
} | ||
|
||
public int getTotalPages() { | ||
return totalPages; | ||
} | ||
|
||
public void setTotalPages(int totalPages) { | ||
this.totalPages = totalPages; | ||
} | ||
|
||
public LocalDateTime getLastUpdated() { | ||
return lastUpdated; | ||
} | ||
|
||
public void setLastUpdated(LocalDateTime lastUpdated) { | ||
this.lastUpdated = lastUpdated; | ||
} | ||
|
||
public AuthorDTO getAuthor() { | ||
return author; | ||
} | ||
|
||
public void setAuthor(AuthorDTO author) { | ||
this.author = author; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having
AuthorDto
asBookDto
field should work but compiler gives this errorSo we might need to check nested types if compatible. I will commit potential fix for this, but still
SELECT
does not use this joined entity and mapper also does not consider it when reading data.