Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change pc2 time stamp to match lidar time stamp #17

Open
adelmhi opened this issue Sep 18, 2024 · 4 comments
Open

Change pc2 time stamp to match lidar time stamp #17

adelmhi opened this issue Sep 18, 2024 · 4 comments

Comments

@adelmhi
Copy link

adelmhi commented Sep 18, 2024

Issue description

the pc2_msg published with the topic /cloud_in takes as time stamp the rclcpp::Node::now() function. Since the point cloud is supposed to combine and replicate lidar signal, it would make more sens to use the timestamp of the laser1_ message.

Possible fix

https://github.com/mich1342/ros2_laser_scan_merger/blob/fd0468edd547bf2e2da85372e76de4a31f5ed118/src/main.cpp#L218C1-L218C13
pc2_msg_->header.stamp = now();

CHange this line to pc2_msg_->header.stamp = laser1_->header.stamp;

@mich1342
Copy link
Owner

Hi, I agree with your points. Will do some changes later on this weekend. Thank you

@mich1342
Copy link
Owner

mich1342 commented Oct 3, 2024

I am sorry, I have not got time recently to make the update. Will try to do and test for the update later this weekend

@adelmhi
Copy link
Author

adelmhi commented Nov 26, 2024

Hello Michael,
Hope you're dong well ! Have you got a change to look into this issue ? Thank you !

@mich1342
Copy link
Owner

Hi @KenStonck ,

Unfortunately I still have not got any time to test the updated code. I have not got any access to my current hardware right now. Will let you know once I got chance to test it with a real hardware before publishing an update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants