From 81f35ac506520b0f1781028fc2d0efe62781e881 Mon Sep 17 00:00:00 2001 From: Marius Felkner Date: Mon, 19 Feb 2024 08:31:43 +0100 Subject: [PATCH] REMOVE todos added them as issues on gh --- .../TuistPluginOutdated/Commands/SubCommands/Outdated.swift | 1 - .../Core/ShellOutService/ShellOutServiceError.swift | 3 +-- .../Data/PackageVersion/PackageVersionRemoteDS.swift | 1 - .../Domain/PrintDependencies/PrintDependenciesUseCase.swift | 1 - 4 files changed, 1 insertion(+), 5 deletions(-) diff --git a/Sources/TuistPluginOutdated/Commands/SubCommands/Outdated.swift b/Sources/TuistPluginOutdated/Commands/SubCommands/Outdated.swift index daf2e0a..9b1e2ea 100644 --- a/Sources/TuistPluginOutdated/Commands/SubCommands/Outdated.swift +++ b/Sources/TuistPluginOutdated/Commands/SubCommands/Outdated.swift @@ -20,7 +20,6 @@ struct Outdated: ParsableCommand { ) var path: String? - // TODO: fix flag @Flag(name: .long) var verbose: Bool = false diff --git a/Sources/TuistPluginOutdatedFramework/Core/ShellOutService/ShellOutServiceError.swift b/Sources/TuistPluginOutdatedFramework/Core/ShellOutService/ShellOutServiceError.swift index 34fe822..482deea 100644 --- a/Sources/TuistPluginOutdatedFramework/Core/ShellOutService/ShellOutServiceError.swift +++ b/Sources/TuistPluginOutdatedFramework/Core/ShellOutService/ShellOutServiceError.swift @@ -6,7 +6,6 @@ import Foundation -// TODO: streamline error handling and error types enum ShellOutServiceError: CustomNSError, LocalizedError { case commandFailed @@ -19,7 +18,7 @@ enum ShellOutServiceError: CustomNSError, LocalizedError { var errorDescription: String? { switch self { case .commandFailed: - return "Command to retrieve version from remote repository failed. Use --verbose to see more details." + return "The invoked shell command failed." } } } diff --git a/Sources/TuistPluginOutdatedFramework/Data/PackageVersion/PackageVersionRemoteDS.swift b/Sources/TuistPluginOutdatedFramework/Data/PackageVersion/PackageVersionRemoteDS.swift index 26c3a82..a5b47a9 100644 --- a/Sources/TuistPluginOutdatedFramework/Data/PackageVersion/PackageVersionRemoteDS.swift +++ b/Sources/TuistPluginOutdatedFramework/Data/PackageVersion/PackageVersionRemoteDS.swift @@ -29,7 +29,6 @@ public final class PackageVersionRemoteDSImpl: PackageVersionRemoteDSInterface { if let latestVersion = try? shellOutService.run(command: command) { guard let currentVersionString = resolvedPackage.version, let currentVersion = Version(currentVersionString) else { - // TODO: handle diff current (e.g. hash) return [] } diff --git a/Sources/TuistPluginOutdatedFramework/Domain/PrintDependencies/PrintDependenciesUseCase.swift b/Sources/TuistPluginOutdatedFramework/Domain/PrintDependencies/PrintDependenciesUseCase.swift index 650b543..f39c956 100644 --- a/Sources/TuistPluginOutdatedFramework/Domain/PrintDependencies/PrintDependenciesUseCase.swift +++ b/Sources/TuistPluginOutdatedFramework/Domain/PrintDependencies/PrintDependenciesUseCase.swift @@ -14,7 +14,6 @@ public protocol PrintDependenciesUseCase { public final class PrintDependenciesUseCaseImpl: PrintDependenciesUseCase { public init() {} - // TODO: coloring public func makeTable(from dependencies: [Dependency]) -> String { let packageNameColumn = TextTableColumn(header: "Package") let packageUrlColumn = TextTableColumn(header: "URL")