Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transformable attributes sync fix for NSSecureUnarchiveFromDataTransformer #181

Closed
wants to merge 2 commits into from
Closed

transformable attributes sync fix for NSSecureUnarchiveFromDataTransformer #181

wants to merge 2 commits into from

Conversation

BlixLT
Copy link
Contributor

@BlixLT BlixLT commented Apr 26, 2022

As mentioned in #177 - NSSecureUnarchiveFromDataTransformer use "reversed" methods from basic ValueTransformers:
transformedValue: is being used when unarchiving Data and reverseTransformedValue: - when archiving some object to Data.
So, I suggest this code to fix #177 crash

@mentrena
Copy link
Owner

@BlixLT thanks for the PR, it's been helpful in understanding the problem. The fix doesn't require different logic for NSSecureUnarchiveFromDataTransformer though, it has more to do with the fact that the calls to transformedValue and reverseTransformedValue were flipped, so I'll fix that in #182

@mentrena mentrena closed this May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Termination: Cannot unarchive type from non-NSData object.
2 participants
@BlixLT @mentrena