Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependency on remark to ^13 for compatibility with plugins #1536

Closed
marcofranssen opened this issue May 6, 2021 · 5 comments
Closed
Labels

Comments

@marcofranssen
Copy link

Subject of the feature

Updating the remark version. I require at least remark 13.

Problem

Some of the remark plugins (e.g. remark-gfm) require an updated version of remark.

$ yarn install 
[remark-gfm] Warning: please upgrade to remark 13 to use this plugin

My dependencies are listed below. The problem started when I switched from remark-html to next-mdx-remote.

  "dependencies": {
    "@fortawesome/fontawesome-svg-core": "^1.2.35",
    "@fortawesome/free-brands-svg-icons": "^5.15.3",
    "@fortawesome/free-solid-svg-icons": "^5.15.3",
    "@fortawesome/react-fontawesome": "^0.1.14",
    "@tailwindcss/typography": "^0.4.0",
    "classnames": "2.3.1",
    "date-fns": "2.21.1",
    "gray-matter": "4.0.3",
    "js-yaml": "^4.1.0",
    "next": "latest",
    "next-mdx-remote": "^2.1.4",
    "react": "^17.0.1",
    "react-dom": "^17.0.1",
    "remark": "13.0.0",
    "remark-autolink-headings": "^6.0.1",
    "remark-emoji": "^2.2.0",
    "remark-external-links": "^8.0.0",
    "remark-gfm": "^1.0.0",
    "remark-slug": "^6.0.0"
  },
  "devDependencies": {
    "autoprefixer": "^10.2.1",
    "next-remote-watch": "^1.0.0",
    "postcss": "^8.2.13",
    "tailwindcss": "^2.1.2"
  },

Expected behavior

Remark GFM can be used without the warning.

Alternatives

N.A.

Additional info

hashicorp/next-mdx-remote#122

@marcofranssen marcofranssen added 🙉 open/needs-info This needs some more info 🦋 type/enhancement This is great to have labels May 6, 2021
@marcofranssen marcofranssen changed the title Upgrade remark dependency to remark 13 for compatibility with plugins Upgrade dependency on remark 13 for compatibility with plugins May 6, 2021
@marcofranssen marcofranssen changed the title Upgrade dependency on remark 13 for compatibility with plugins Upgrade dependency on remark to ^13 for compatibility with plugins May 6, 2021
@ChristianMurphy
Copy link
Member

This is part of mdx 2 #1041
You can try out the remark 13 compatible version in the pre-release of version 2

@ChristianMurphy ChristianMurphy added 👯 no/duplicate Déjà vu and removed 🙉 open/needs-info This needs some more info 🦋 type/enhancement This is great to have labels May 6, 2021
@marcofranssen
Copy link
Author

@ChristianMurphy what would be the expected timeline for GA of version 2?

@ChristianMurphy
Copy link
Member

Not exactly sure, the most recent I've heard was https://twitter.com/mdx_js/status/1340680033971687424, but that didn't quite pan out.

@ChristianMurphy
Copy link
Member

Another option is XDM (https://github.com/wooorm/xdm) which is a lighter implementation of MDX 2, which has remark ^13 on it's stable release.

@bluprince13
Copy link

@marcofranssen - did you find a solution to this? Also, does remark-gfm not work for you at all? It doesn't for me. I'm surprised it says warning than error if it isn't going to work at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants